cpufreq: fix compilation of ACPI if !CPU_FREQ [Was: Re: [PATCH UPDATED] cpufreq: move frequency table helpers to extra module]

cpufreq: fix compilation of ACPI if !CPU_FREQ [Was: Re: [PATCH UPDATED] cpufreq: move frequency table helpers to extra module]

Post by Dominik Brodowsk » Mon, 17 Feb 2003 01:00:18




> Dominic,
>  this broke ACPI.

>    In file included from drivers/acpi/processor.c:49:
>    include/acpi/processor.h:78: field `freq_table' has incomplete type

> AGAIN.

> For about the 15th time.

> You guys need to talk more. A LOT more. Or y ou need to start checking who
> is actually _using_ the frequency code, and when you make changes to the
> interfaces you need to _update_ the users, instead of just causing kernel
> compiles to fail every frigging time you make a change.

>            Linus

Linus,

here's the compile fix for this breakage which only appears if
CONFIG_ACPI && !(CONFIG_CPU_FREQ_TABLE || CONFIG_CPU_FREQ_TABLE_MODULE)
Unfortunately, I forgot to test-compile this combination. Sorry about
that.

        Dominik

diff -u linux-original/include/linux/cpufreq.h linux/include/linux/cpufreq.h
--- linux-original/include/linux/cpufreq.h      2003-02-15 23:35:14.000000000 +0100

 #endif /* CONFIG_CPU_FREQ_24_API */

-#if defined(CONFIG_CPU_FREQ_TABLE) || defined(CONFIG_CPU_FREQ_TABLE_MODULE)
+
 /*********************************************************************
  *                     FREQUENCY TABLE HELPERS                       *

                                    * order */
 };

+#if defined(CONFIG_CPU_FREQ_TABLE) || defined(CONFIG_CPU_FREQ_TABLE_MODULE)
 int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
                                    struct cpufreq_frequency_table *table);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/