warning fixes for flags in spin_lock_irqsave

warning fixes for flags in spin_lock_irqsave

Post by Andries.Brou.. » Wed, 23 Apr 2003 14:30:15



diff -u --recursive --new-file -X /linux/dontdiff a/drivers/net/epic100.c b/drivers/net/epic100.c
--- a/drivers/net/epic100.c     Sat Jan 18 23:54:29 2003

        struct epic_private *ep = dev->priv;
        int entry, free_count;
        u32 ctrl_word;
-       long flags;
+       unsigned long flags;

        if (skb->len < ETH_ZLEN) {

        } else if (dev->mc_count == 0) {
                outl(0x0004, ioaddr + RxCtrl);
                return;
-       } else {                                        /* Never executed, for now. */
+       } else {                                /* Never executed, for now. */
                struct dev_mc_list *mclist;

                memset(mc_filter, 0, sizeof(mc_filter));
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/net/ns83820.c b/drivers/net/ns83820.c
--- a/drivers/net/ns83820.c     Sat Feb 15 20:41:57 2003

 static inline int rx_refill(struct ns83820 *dev, int gfp)
 {
        unsigned i;
-       long flags = 0;
+       unsigned long flags = 0;

        if (unlikely(nr_rx_empty(dev) <= 2))

 static void ns83820_cleanup_rx(struct ns83820 *dev)
 {
        unsigned i;
-       long flags;
+       unsigned long flags;

        dprintk("ns83820_cleanup_rx(%p)\n", dev);

        struct rx_info *info = &dev->rx_info;
        unsigned next_rx;
        u32 cmdsts, *desc;
-       long flags;
+       unsigned long flags;
        int nr = 0;


 {
        struct ns83820 *dev = (struct ns83820 *)_dev;
         u32 tx_done_idx, *desc;
-       long flags;
+       unsigned long flags;

        local_irq_save(flags);

diff -u --recursive --new-file -X /linux/dontdiff a/drivers/net/sundance.c b/drivers/net/sundance.c
--- a/drivers/net/sundance.c    Sat Jan 18 23:54:39 2003

 {
        struct netdev_private *np = dev->priv;
        long ioaddr = dev->base_addr;
-       long flag;
+       unsigned long flag;

        netif_stop_queue(dev);
        tasklet_disable(&np->tx_tasklet);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

warning fixes for flags in spin_lock_irqsave

Post by Jeff Garzi » Wed, 23 Apr 2003 14:30:25


Already sent to, and committed by, Linus.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. compilation fix: spin_lock_irqsave uses unsigned long

diff -u --recursive --new-file -X /linux/dontdiff a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
--- a/drivers/block/paride/pcd.c        Tue Apr  8 09:36:36 2003

 static inline void next_request(int success)
 {
-       long saved_flags;
+       unsigned long saved_flags;

        spin_lock_irqsave(&pcd_lock, saved_flags);
        end_request(pcd_req, success);
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
--- a/drivers/block/paride/pd.c Tue Apr  8 09:36:36 2003

 static int pd_next_buf(void)
 {
-       long saved_flags;
+       unsigned long saved_flags;

        pd_count--;

 static inline void next_request(int success)
 {
-       long saved_flags;
+       unsigned long saved_flags;

        spin_lock_irqsave(&pd_lock, saved_flags);
        end_request(pd_req, success);
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c
--- a/drivers/block/paride/pf.c Sun Apr 20 12:59:31 2003

 static int pf_next_buf(void)
 {
-       long saved_flags;
+       unsigned long saved_flags;

        pf_count--;

 static inline void next_request(int success)
 {
-       long saved_flags;
+       unsigned long saved_flags;
+
        spin_lock_irqsave(&pf_spin_lock, saved_flags);
        end_request(pf_req, success);
        pf_busy = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. LPD Hold Up ...

3. Warning: Invalid flag 0000 - Help

4. printing to a printer as "landscape" instead of "portrait"

5. WARNING: invalid flag 0000 of partition table 4 will be corrected by w(rite)

6. CDRom Mounting Problems

7. Warning: invalid flag 0000 of partition table 4 will be corrected by w(rite)

8. Adding a second hard drive -- file system layout advice?

9. ide driver bug fix for the error message "hda: bad special flag 0x03"

10. fix up newer x86 cpuinfo flags.

11. 2.5 and 2.4: fix PCI IO BAR flags

12. Fix flags definitions to be longs