page-writeback.c compile warning fix

page-writeback.c compile warning fix

Post by Robert Lov » Thu, 25 Jul 2002 06:00:16



Andrew and Linus,

Compile of mm/page-writeback.c gives a warning of undefined use of
"writeback_backing_dev()".

Patch is against 2.5.27, please apply.

        Robert Love

diff -urN linux-2.5.27/include/linux/backing-dev.h linux/include/linux/backing-dev.h
--- linux-2.5.27/include/linux/backing-dev.h    Sat Jul 20 12:11:12 2002

 int writeback_acquire(struct backing_dev_info *bdi);
 int writeback_in_progress(struct backing_dev_info *bdi);
 void writeback_release(struct backing_dev_info *bdi);
+void writeback_backing_dev(struct backing_dev_info *bdi, int *nr_to_write,
+       enum writeback_sync_modes sync_mode, unsigned long *older_than_this);

 #endif         /* _LINUX_BACKING_DEV_H */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

page-writeback.c compile warning fix

Post by Andrew Morto » Thu, 25 Jul 2002 06:10:06



> Andrew and Linus,

> Compile of mm/page-writeback.c gives a warning of undefined use of
> "writeback_backing_dev()".

Yeah, sorry.  I missed a file when generating the diff.  I have
this in the pending pile:

 writeback.h |    5 +++++
 1 files changed, 5 insertions(+)

--- 2.5.27/include/linux/writeback.h~writeback-warning  Mon Jul 22 12:33:39 2002

 #ifndef WRITEBACK_H
 #define WRITEBACK_H

+struct backing_dev_info;
+
 extern spinlock_t inode_lock;
 extern struct list_head inode_in_use;

 void __wait_on_inode(struct inode * inode);
 void sync_inodes_sb(struct super_block *, int wait);
 void sync_inodes(int wait);
+void writeback_backing_dev(struct backing_dev_info *bdi, int *nr_to_write,
+                       enum writeback_sync_modes sync_mode,
+                       unsigned long *older_than_this);

 /* writeback.h requires fs.h; it, too, is not included from here. */
 static inline void wait_on_inode(struct inode *inode)

.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. [TRIVIAL] spelling fix for page-writeback.c

Hi,

I found this spelling fix in Craig Kulesa's minimal rmap patch.

Rik
--
Bravely reimplemented by the knights who say "NIH".

diff -Nru a/mm/page-writeback.c b/mm/page-writeback.c
--- a/mm/page-writeback.c       Fri Jul  5 15:42:39 2002

  * If a page is already under I/O, generic_writepages() skips it, even
  * if it's dirty.  This is desirable behaviour for memory-cleaning writeback,
  * but it is INCORRECT for data-integrity system calls such as fsync().  fsync()
- * and msync() need to guarentee that all the data which was dirty at the time
+ * and msync() need to guarantee that all the data which was dirty at the time
  * the call was made get new I/O started against them.  The way to do this is
  * to run filemap_fdatawait() before calling filemap_fdatawrite().
  *

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. PGP Compilation

3. 2.5.26 buffer layer error at page-writeback.c:420

4. Configuring arrow keys in xterm

5. Call trace at mm/page-writeback.c in 2.5.47

6. Disk Geometry?

7. direct-to-BIO writeback for writeback-mode ext3

8. AIX 4.3.3 and ioctl versyss tcsetattr

9. 2.5.65 fix jiffies compile warning in alpha/kernel/smp.c

10. [CIFS] Fix compile warning for fs/cifs/cifsfs.c

11. trivisl sg.c compile warning fix

12. Fix 4 compile time warnings in 2.5.53

13. fix a writeback race