DevFS support for /dev/cpu/X/(cpuid|msr)

DevFS support for /dev/cpu/X/(cpuid|msr)

Post by Richard Gooc » Wed, 20 Feb 2002 04:30:11



Quote:Ishan Jayawardena writes:
> This is a multi-part message in MIME format.

First comment: please send the patch inline, not MIME-encoded.

Quote:> I'd love to extend this work to support Paul Russell's hotplug cpu work, but
> I have absolutely no way at present to test it. (If some kind party would
> like to donate a quad pentium 4 Xeon with hotplug cpu support, I'll be more
> than happy to do so ;)

> This is against 2.4.18-pre9-ac4 with devfs v199.9

> Relevent comments, advise, improvisations, flames, welcome.

Second comment: devfs_(un)register_per_cpu() doesn't belong in
fs/devfs/base.c. I don't even think it should be in fs/devfs/util.c.
I think it belongs kernel/smp.c (that's right, create a new file).
There's too much duplicated SMP code in each arch/ tree. Let's create
a place for new stuff to be shared.

So, please send along your next version of the patch (inlined, of
course:-).

                                Regards,

                                        Richard....


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. DevFS support for /dev/cpu/X/(cpuid|msr)

Looks mostly reasonable, except for:

There is no need to remove the parent /dev/cpu/%d directory, and in
fact it's better not to. All you need is this simpler loop:
        for(i = 0; i < NR_CPUS; i++)
                devfs_unregister(devfs_handle[i]);

You do something similar in the MSR driver.

                                Regards,

                                        Richard....


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Partition Hard Disk

3. 2.4.19 CPUID, MSR: add devfs support

4. ZIP Plus - need imm.tar.gz

5. add devfs support to cpuid and msr

6. Should I make a new boot disk?

7. cpuid/msr + devfs

8. Dynamic binding problem

9. Howto use /dev/cpu/%d/msr

10. 2.4.19 - 2.4.21-pre5 TM5600 /dev/cpu/0/cpuid incompatible with longrun

11. PATCH 2.5.2.6: fix cpuid, msr builds

12. [devfs] Utility functions to handle /dev/cpu/