include order for i2c-amd8111

include order for i2c-amd8111

Post by Pavel Mache » Tue, 07 Jan 2003 01:20:07



Hi!

It seems all linux then all asm is prefered order...
                                                                Pavel

--- clean/drivers/i2c/busses/i2c-amd8111.c      2003-01-05 22:58:27.000000000 +0100

 #include <linux/version.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <asm/io.h>
 #include <linux/kernel.h>
 #include <linux/stddef.h>

 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/delay.h>
+#include <asm/io.h>

 MODULE_LICENSE("GPL");

--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

include order for i2c-amd8111

Post by Rusty Russel » Tue, 07 Jan 2003 02:50:05



Quote:> Hi!

> It seems all linux then all asm is prefered order...
>                                                            Pavel

Yes, but not for any great reason, AFAICT.  I think this comes under
the "too trivial" rule (ie.  I'll accept it from the author, but not
someone else).

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

include order for i2c-amd8111

Post by Vojtech Pavli » Wed, 08 Jan 2003 12:50:06




> > Hi!

> > It seems all linux then all asm is prefered order...
> >                                                               Pavel

> Yes, but not for any great reason, AFAICT.  I think this comes under
> the "too trivial" rule (ie.  I'll accept it from the author, but not
> someone else).

The author (me ;) definitely doesn't mind you applying the patch, but
would prefer if the one who pushed the 8111 driver into the kernel
(Pavel) would update it to the version found in lm_sensors 2.7.0 at the
same time.

Thanks.

--
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

include order for i2c-amd8111

Post by Pavel Mache » Sat, 11 Jan 2003 20:20:10


Hi!

Quote:> > > It seems all linux then all asm is prefered order...
> > >                                                          > > Yes, but not for any great reason, AFAICT.  I think this comes under
> > the "too trivial" rule (ie.  I'll accept it from the author, but not
> > someone else).

> The author (me ;) definitely doesn't mind you applying the patch, but
> would prefer if the one who pushed the 8111 driver into the kernel
> (Pavel) would update it to the version found in lm_sensors 2.7.0 at the
> same time.

Do you think you can mail me that file?

                                Pavel

--
                                Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/