Patch?: linux-2.5.45/net - __secpath_destroy made net depend on ipv4

Patch?: linux-2.5.45/net - __secpath_destroy made net depend on ipv4

Post by Adam J. Richte » Sat, 02 Nov 2002 12:50:08



        In linux-2.5.45, the core networking code calls
__secpath_destroy via the static inline routine secpath_put in
include/net/xfrm.h.  However, __secpath destroy is defined in
ipv4.  So, I believe that compiling networking without ipv4
will result in a kernel that fails to link (haven't actually
tried it), and it also causes problems for anyone who has
tweaked ipv4 into a loadable module (which is my case; I posted
patches long ago and would be happy to post them again if there
is interest).

        Here is a possible patch that creates a secpath_destroy_hook,
although I hope that a cleaner and safer solution can be found (safer
because hook variables if multiple modules save and restore the old
values of the hook variable in some order other than
last-in-first-out).

        I'm littering linux-kernel with this patch also because I
think __secpath_destroy comes from ipsec and those maintainers might
not be on the netdev and linux-net lists.

--
Adam J. Richter     __     ______________   575 Oroville Road

+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

  secpath.diffs
2K Download
 
 
 

Patch?: linux-2.5.45/net - __secpath_destroy made net depend on ipv4

Post by David S. Mille » Sat, 02 Nov 2002 13:10:08



   Date: Fri, 1 Nov 2002 03:45:00 -0800

        In linux-2.5.45, the core networking code calls
   __secpath_destroy via the static inline routine secpath_put in
   include/net/xfrm.h.

Yes, we are fully aware of this.  It will be fixed in due time,
please use CONFIG_INET=y kernels for the time being.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Patch?: linux-2.5.45/net/ipv4/netfilter dst.pmtu compilation fixes

also see
http://marc.theaimsgroup.com/?l=linux-kernel&m=103614599321384&w=1

linux-2.5.45 appears to have replaced dst_entry.pmtu with
dst_entry.metrics[RTAX_PMTU] and created a helper function
dst_pmtu(struct dst_entry*), presumably to simplify future changes
like this one.   Now the
files compile.  That is as much as I have tested.

 I am not currently familiar with this code, so I could easily
have misunderstood something in this patch.

--- linux-2.5.45.orig/net/ipv4/netfilter/ipt_TCPMSS.c   2002-10-31
01:42:56.000000000 +0100
+++ linux-2.5.45/net/ipv4/netfilter/ipt_TCPMSS.c        2002-11-01

                        return NF_DROP; /* or IPT_CONTINUE ?? */
                }

-               if((*pskb)->dst->pmtu <= (sizeof(struct iphdr) +
sizeof(struct tcphdr))) {
+               if( dst_pmtu( (*pskb)->dst ) <= (sizeof(struct iphdr) +
sizeof(struct tcphdr))) {
                        if (net_ratelimit())
                                printk(KERN_ERR
-                                       "ipt_tcpmss_target: unknown or
invalid path-MTU (%d)\n", (*pskb)->dst->pmtu);
+                                       "ipt_tcpmss_target: unknown or
invalid path-MTU (%d)\n", dst_pmtu( (*pskb)->dst ) );
                        return NF_DROP; /* or IPT_CONTINUE ?? */
                }

-               newmss = (*pskb)->dst->pmtu - sizeof(struct iphdr) -
sizeof(struct tcphdr);
+               newmss = dst_pmtu( (*pskb)->dst ) - sizeof(struct iphdr)
- sizeof(struct tcphdr);
        } else
                newmss = tcpmssinfo->mss;

--
+----------------------------------------------+
|Jaquemet Loic                                 |
|Intern in WesternGeco, Schlumberger in Gatwick|
|Phone: 44-(0)1293-55-6876                     |
|Eleve ingenieur en informatique FIIFO, ORSAY  |
+----------------------------------------------+
http://sourceforge.net/projects/ffss/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. 5.0.4 on IBM - No warm boot

3. Patch?: linux-2.5.45/net/ipv4/ dst.pmtu compilation fixes

4. massive compile failures w/ 2.5.51 on RH8.0

5. ipv4: move proc stuff from net/ipv4/af_inet.c to net/ipv4/proc.c

6. From your friends at

7. Patch: linux-2.5.7-pre1/net/ipv4/ipmr.c did not compile

8. strtol

9. move /proc/net/udp support back to net/ipv4/udp.c

10. net/ipv4/*, net/core/neighbour.c jiffies cleanup

11. [PATCH] Linux-2.5.45-mcp3 - right one

12. Patch: linux-2.5.45/fs/fcblist.c - export symbols for unix sockets

13. [PATCH] Linux-2.5.45-mcp2