fix for pci_enable_device in 2.4.19ac3

fix for pci_enable_device in 2.4.19ac3

Post by Jeremy Fitzharding » Tue, 06 Aug 2002 14:40:05



I found my tulip driver was complaining about not being able to enable
the device.  Turns out this was the problem:


 int
 pci_enable_device(struct pci_dev *dev)
 {
-       pci_enable_device_bars(dev, 0x3F);
+       return pci_enable_device_bars(dev, 0x3F);
 }

 /**

I guess nobody else checks their error returns (or it just happened to
always return 0).

        J

[ sorry about the resend; forgot to turn off HTML ]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. 2.4.19rc2 -> 2.4.19rc3 : no more eth

Dear kernel crew.

I follow the stable kernel and run 2.4.18 just fine on 3 machines.

Recently I thought about trying 2.4.19rc kernels.  That went fine as
well with one exception.

One machine (with 2 ethernet controllers)
 Intel Corp. 82557/8/9 [Ethernet Pro 100] (rev 0c)
 3Com Corporation 3c900B-TPO [Etherlink XL TPO] (rev 04)
will no longer recognise -any- of those.

Note that this 'artifact' only happens with 2.4.19rc3.  The .config
between 2.4.19rc2 did not change 2.4.19rc3

During boot I see OOPses (which for some reason, my syslog does not
see).

Because this is a rather severe change [:-)] I wonder if I this rings
a bell.

Thanks for your valuable time

--
 Greetings,

Marc Duponcheel     Multicast Development Engineer      Cisco Systems

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Problem with STREAMS

3. Kernel patching 2.4.19pre1 -> 2.4.19pre2

4. Errors in Server Log Files

5. Promise 20267 hangs with 2.4.19-pre3 and 2.4.19-pre3-ac3

6. Keypad indistingushable from 'prior' keys

7. Kernel panic 2.4.19-pre6 AND 2.4.19-pre5-ac3 - More info - ksymoops

8. Large Block Device testing -- preliminary results.

9. kbuild25 version 3.0 for 2.4.19-pre9 and 2.4.19-pre9-ac3

10. Linux 2.4.19pre2-ac3

11. Linux 2.4.19pre2-ac2 || Linux 2.4.18-ac3, compilation error on SPARC

12. Linux 2.4.19pre9-ac3

13. 2.4.19rc3-ac3 --> sched.c errors