[Trivial] Columns in n_tty.c

[Trivial] Columns in n_tty.c

Post by Chris Heat » Mon, 23 Jun 2003 20:10:09

Here's a column counting bug that was lurking in a corner of n_tty.c.

The patch is against 2.5.72, but it applies to 2.4.21 too (with an


--- a/drivers/char/n_tty.c      2003-06-19 21:51:27.000000000 -0400

        if (tty->erasing) {
                put_char('/', tty);
-               tty->column += 2;
+               tty->column++;
                tty->erasing = 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


1. Trivial Patch Policy (trivial@rustcorp.com.au)

Hi all,

        I've been collecting trivial patches for a few months now, and
it's time to solidify some rules:

1) Trivial patches must qualify for one of the following to be
        a) Spelling fixes (useful for grep, and sets a good example)
        b) Warning fixes (cluttering with useless warnings is bad)
        c) Compilation fixes (only if they are actually correct)
        d) Runtime fixes (only if they actually fix things)
        e) Removing use of deprecated functions/macros (eg. check_region).
        f) Contact detail and documentation fixes
        g) Non-portable code replaced by portable code
           (even in arch-specific, since people copy, as long as it's trivial)
        h) Any fix by the author/maintainer of the file.
           (ie. patch monkey in re-transmission mode)

   They must also be "trivial" by my definition of trivial.  Best
   patches contain enough context for me to judge without opening the
   file (diff -C<nn> -u is your friend).

   NOTE: This means I'll only take whitespace/indentation fixes from
   the author or maintainer.

2) The patch will not be forwarded to anyone until a new kernel has
   been released after I receive the patch, *unless* noone else is
   sent the patch.  So if you cc: the trivial patch monkey, it'll only
   be forwarded from there if it doesn't make the next kernel.

3) The first time the patch is forwarded, it will be sent to the
   author and/or maintainer.  If they say they've included it in their
   tree, no more forwards will occur (modulo some timeout eventually).
   If they NAK it, the patch will be closed.  Otherwise, the patch
   will be sent directly to Linus or Marcelo on future forwards (the
   maintainer will still be cc'd).

Hopefully this will be a good compromise between coordinating with
maintainers who want control of their files, and stopping trivial
patches from slipping through the cracks.

Rusty, aka the Trivial Patch Monkey.
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Servlets in C++

3. sed/awk : need just the first column in a multi-column file

4. HACMP Ultra2 SCSI

5. Newbie: adding and averaging columns, based on feature in column 2 (awk?)

6. Help Upgrading gcc

7. Sorting By Second Column With Unique First Column

8. \

9. AIX Script to Summarize By First Column By Adding Values in Numerical Columns

10. arrange columns and find average of each column

11. setting 100-column & 132-column modes

12. n_tty.c driver patch (semantic and performance correction) (a ll recent versions)