Very Computer

by **Steven Walte** » Mon, 18 Jun 2001 03:30:06

This patch is obviously correct. It doesn't appear that tdfxfb has a
maintainer, so I'm sending this patch to the list. Nothing
earth-shattering, it just removes a warning during build.
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell

--- tdfxfb.c~ Sat Jun 16 13:09:08 2001

((pdev->device == PCI_DEVICE_ID_3DFX_BANSHEE) ||
(pdev->device == PCI_DEVICE_ID_3DFX_VOODOO3) ||
(pdev->device == PCI_DEVICE_ID_3DFX_VOODOO5))) {
- char *name;
+ char *name = NULL;

fb_info.dev = pdev->device;
switch (pdev->device) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

by **Steven Walte** » Mon, 18 Jun 2001 04:30:08

I'm using 2.95.2; perhaps its fixed in 2.96/CVS?

> > This patch is obviously correct. It doesn't appear that tdfxfb has a
> > maintainer, so I'm sending this patch to the list. Nothing

> > earth-shattering, it just removes a warning during build.

> Yep.. Im actually suprised gcc couldnt work that one out itself.

--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

by **Steven Walte** » Mon, 18 Jun 2001 05:20:07

> It might be better to add a default case to the switch statement below, so
> this symbol doesn't just eat up another 4(8 on some platforms, and i'm
> sure others) bytes of memory unneccesarily.

I'm not quite sure I follow you. The default case should never be
reached, because only the three cases currently present are allowed by
the encapsulating 'if' statement. Even so, how would adding a default
case get rid of the variable or save space some other way?

Quote:> anyway, it doesn't really matter. i'd test my hypothesis, but i've got
> people coming over this afternoon =) the driver looks like it might use
> some scrubbing anyway (s!//(.*)$!/\* $1 \*/!...)

Good point. Perhaps I'll prepare a larger patch with this and other
cleanups.
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Very Computer

fix warning in tdfxfb.c

fix warning in tdfxfb.c

fix warning in tdfxfb.c

fix warning in tdfxfb.c