Patch?: linux-2.5.2-pre8/drivers/video kdev_t compilation fixes

Patch?: linux-2.5.2-pre8/drivers/video kdev_t compilation fixes

Post by Adam J. Richte » Sun, 06 Jan 2002 16:20:09

        Most (all?) of the frame buffer drivers in
linux-2.5.2-pre8/drivers/video have a kdev_t compilation error,
because they try to set their fb_info->node field to -1 (it is
a kdev_t).  Shortly thereafter, regsiter_framebuffer sets it to
a more useful value.  So far, I have been unable to spot any
code that relies on fb_info->node being initialized to a
particular value prior to the call to register_framebuffer,
although I have not looked very hard.  What I did see was
some "???" comments beside some of the initializations to -1.
I suspsect that this is just useless initialization.

        Anyhow, deleting all of those initializations to -1
allows all of the framebuffer drivers to compile, which is
that this patch does.  I have also included a tiny patch to
a commented out line in include/linux/fb.h, updating it to
use minor() instead of MINOR(), in case it is every uncommented.

        I am still a long way from getting pre8 to run, so I
have not tested change.  Can anyone point out a place in
drivers/framebuffer that relies on fb_info->node being set to -1,
or minor(fb_info->node) being -1?

        By the way, don't worry if a few of the line offsets in this
patch are off.  That's because of some other changes I have in my
drivers/framebuffer (which I have previous posted, specifically
PCI ID tables, fb font modularization with demand loading, and the
fb core as a loadable module).

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104

+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."

21K Download

1. Patch: linux-2.5.2-pre8/drivers/ieee1394 kdev_t compilation fixes

I'll get this checked into CVS today. I planned on a sync with Linus
soon anyway.

Andreas, now would be a good time for us to branch 2.2.x support in CVS
to simplify 2.4.x/2.5.x compatibility.

/                   Ben Collins    --    Debian GNU/Linux                  \

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at
Please read the FAQ at

2. ISDN Calling problems

3. linux-2.5.2-pre8/drivers/telephony kdev_t compilation fixes

4. bash history

5. Patch: linux-2.5.2-pre8/drivers/mtd compilation fixes

6. No sound snd-intel8x0 Mandriva2006

7. Patch: linux-2.5.2-pre8/drivers/sound compilation fixes: MINOR-->minor

8. Help needed with smail error

9. Patch: linux-2.5.2-pre8/drivers/md partial compilation fixes

10. PATCH: linux-2.5.2-pre7/drivers/block/rd.c kdev_t fix

11. Patch?: linux-2.5.6-pre1/drivers/scsi/pci2000.c compilation fixes + pci device ID table

12. kdev_t compilation fixes (Framebuffer)

13. PATCH fbdev kdev_t build fixes