Very Computer

In drivers/pcmcia/cardbus.c in cb_alloc(), PCI_INTERRUPT_LINE and
dev->irq are not filled in until after calling pci_enable_device().
The result is a cryptic message like:

Quote:> PCI: No IRQ known for interrupt pin A of device 01:00.0. Please try using pci=biosirq.

Unless there is a less obvious reason for the ordering, I suggest the
following one-liner.

-- Dave Hinds

--- cardbus.c.orig      Fri Mar  2 09:49:46 2001

                        if (res->flags)
                                pci_assign_resource(dev, r);
                }
-               pci_enable_device(dev); /* XXX check return */

                /* Does this function have an interrupt at all? */

                        pci_writeb(dev, PCI_INTERRUPT_LINE, irq);
                }

+               pci_enable_device(dev); /* XXX check return */
                pci_insert_device(dev, bus);
        }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Agreed.

In fact, we shouldn't need to enable the device at all: the drivers are
supposed to do the pci_enable_device() themselves. But let's do the
minimal "move it down a few lines" thing for now.

Thanks,

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/