patch 06/38: CLIENT: change inode to dentry in ->readdir() nfs_rpc_op

patch 06/38: CLIENT: change inode to dentry in ->readdir() nfs_rpc_op

Post by Kendrick M. Smit » Thu, 15 Aug 2002 08:10:05



This patch changes the interface of the ->readdir() nfs_rpc_op
so that its first argument is a dentry instead of an inode.

[Explanation: The dentry is required because in NFSv4, we need
 to make use of the _parent_ directory's inode.  This is because
 NFSv4 servers no longer return an entry for ".." in the READDIR
 response, so the client kernel needs to fake this entry, inode
 number and all.]

--- old/include/linux/nfs_xdr.h Wed Jul 24 16:03:23 2002

        int     (*mkdir)   (struct inode *, struct qstr *, struct iattr *,
                            struct nfs_fh *, struct nfs_fattr *);
        int     (*rmdir)   (struct inode *, struct qstr *);
-       int     (*readdir) (struct inode *, struct rpc_cred *,
+       int     (*readdir) (struct dentry *, struct rpc_cred *,
                            u64, struct page *, unsigned int, int);
        int     (*mknod)   (struct inode *, struct qstr *, struct iattr *,
                            dev_t, struct nfs_fh *, struct nfs_fattr *);
--- old/fs/nfs/dir.c    Wed Jul 24 16:03:27 2002

        dfprintk(VFS, "NFS: nfs_readdir_filler() reading cookie %Lu into page %lu.\n", (long long)desc->entry->cookie, page->index);

  again:
-       error = NFS_PROTO(inode)->readdir(inode, cred, desc->entry->cookie, page,
+       error = NFS_PROTO(inode)->readdir(file->f_dentry, cred, desc->entry->cookie, page,
                                          NFS_SERVER(inode)->dtsize, desc->plus);
        /* We requested READDIRPLUS, but the server doesn't grok it */

                status = -ENOMEM;
                goto out;
        }
-       desc->error = NFS_PROTO(inode)->readdir(inode, cred, desc->target,
+       desc->error = NFS_PROTO(inode)->readdir(file->f_dentry, cred, desc->target,
                                                page,
                                                NFS_SERVER(inode)->dtsize,
                                                desc->plus);
--- old/fs/nfs/proc.c   Wed Jul 24 16:03:25 2002

  * from nfs_readdir by calling the decode_entry function directly.
  */
 static int
-nfs_proc_readdir(struct inode *dir, struct rpc_cred *cred,
+nfs_proc_readdir(struct dentry *dentry, struct rpc_cred *cred,
                 u64 cookie, struct page *page, unsigned int count, int plus)
 {
+       struct inode            *dir = dentry->d_inode;
        struct nfs_readdirargs  arg = {
                fh:             NFS_FH(dir),
                cookie:         cookie,
--- old/fs/nfs/nfs3proc.c       Wed Jul 24 16:03:27 2002

  * readdirplus.
  */
 static int
-nfs3_proc_readdir(struct inode *dir, struct rpc_cred *cred,
+nfs3_proc_readdir(struct dentry *dentry, struct rpc_cred *cred,
                  u64 cookie, struct page *page, unsigned int count, int plus)
 {
+       struct inode            *dir = dentry->d_inode;
        struct nfs_fattr        dir_attr;
        u32                     *verf = NFS_COOKIEVERF(dir);
        struct nfs3_readdirargs arg = {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/