Comments for drivers/char/rio

Comments for drivers/char/rio

Post by Anthony J. Breeds-Taurim » Thu, 18 Apr 2002 13:30:11



Rogier,
        Here is an updated version of the patch we discussed back in Febuary.
It has been updated to 2.4.19-pre6.

Alan, Marcelo and LKML
        This patch simply adds a few comments to drivers/char/rio/* to stop
spurious email about functions returning "EBLAH" instead of "-EBLAH"

Yours Tony.

/*
 * "The significant problems we face cannot be solved at the
 * same level of thinking we were at when we created them."
 * --Albert Einstein
 */

--------------------------------------------------------------------------------
diff -urN -X /usr/src/dontdiff linux-2.4.19-pre6.clean/drivers/char/rio/rioboot.c linux-2.4.19-pre6/drivers/char/rio/rioboot.c
--- linux-2.4.19-pre6.clean/drivers/char/rio/rioboot.c  Fri Sep 21 11:10:42 2001

 **

 **
+** Changes:

+**       Code review: Resulted in some clarifying comments to prevent
+**       recurring non-fixes...
+**
 ** -----------------------------------------------------------------------------
 */

                p->RIOError.Error = HOST_FILE_TOO_LARGE;
                /* restore(oldspl); */
                func_exit ();
+               /* This IS correct,  any return values will be translated in rio_linux
+                  Before they are passed out of the driver. -- AJBT & REW */
                return ENOMEM;
        }

diff -urN -X /usr/src/dontdiff linux-2.4.19-pre6.clean/drivers/char/rio/riocmd.c linux-2.4.19-pre6/drivers/char/rio/riocmd.c
--- linux-2.4.19-pre6.clean/drivers/char/rio/riocmd.c   Mon Feb 18 18:02:06 2002

        if ( !CmdBlkP ) {
                rio_dprintk (RIO_DEBUG_CMD, "FOAD RTA: GetCmdBlk failed\n");
+               /* This IS correct,  any return values will be translated in rio_linux
+                  Before they are passed out of the driver. -- AJBT & REW */
                return ENXIO;
        }

diff -urN -X /usr/src/dontdiff linux-2.4.19-pre6.clean/drivers/char/rio/rioctrl.c linux-2.4.19-pre6/drivers/char/rio/rioctrl.c
--- linux-2.4.19-pre6.clean/drivers/char/rio/rioctrl.c  Mon May 14 15:42:42 2001

                                                }
                                        }
                                } else if (host >= p->RIONumHosts) {
+               /* This IS correct,  any return values will be translated in rio_linux
+                  Before they are passed out of the driver. -- AJBT & REW */
                                        return EINVAL;
                                } else {
                                        if ( p->RIOHosts[host].Flags == RC_RUNNING ) {
diff -urN -X /usr/src/dontdiff linux-2.4.19-pre6.clean/drivers/char/rio/riotable.c linux-2.4.19-pre6/drivers/char/rio/riotable.c
--- linux-2.4.19-pre6.clean/drivers/char/rio/riotable.c Mon Oct 22 16:04:39 2001

        rio_dprintk (RIO_DEBUG_TABLE, "RIONewTable: entering(1)\n");
        if ( p->RIOSystemUp ) {              /* (1) */
                p->RIOError.Error = HOST_HAS_ALREADY_BEEN_BOOTED;
+               /* This IS correct,  any return values will be translated in rio_linux
+                  Before they are passed out of the driver. -- AJBT & REW */
                return EBUSY;
        }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Fix compiler errors in drivers/char/rio/rio_linux.c

When the compatmac.h include file was deleted the indirect include
of asm/uaccess.h was lost.  This patch adds a direct include of
asm/uaccess.h.

This fixes bugme.osdl.org bug number 566.

--

Open Source Development Lab                     Phone: 503.626.2455 Ext. 17

===== drivers/char/rio/rio_linux.c 1.16 vs edited =====
--- 1.16/drivers/char/rio/rio_linux.c   Mon Mar 31 15:55:28 2003

 #include <linux/init.h>

 #include <linux/generic_serial.h>
+#include <asm/uaccess.h>

 #if BITS_PER_LONG != 32
 #  error FIXME: this driver only works on 32-bit platforms
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Recordable CD-ROM

3. 2.4.19-pre10 s/Efoo/-Efoo/ drivers/char/rio/*.c

4. Redefining Caps-Lock to be Ctrl?

5. New: compile failure in drivers/char/rio/rio_linux.c

6. need help w/ LILO and 8.4Gb IBM Deskstar HD

7. 2.4.19-pre10 s/Efoo/-Efoo/ drivers/char/rio/*.c UPDATED

8. LD_LIBRARY_PATH corrupted after startx

9. drivers/char/rio/func.h needs linux/kdev_t.h

10. 2.5.50 drivers/char/rio/rioctrl.c

11. 2.2.21 s/Efoo/-Efoo/ drivers/char/rio/*.c

12. drivers/char/Kconfig:640: can't open file "drivers/char/ipmi/Kconfig"

13. char *strcasestr(char *haystack, char *needle) a simple case independent strstr()