kdev_t compilation fixes (Framebuffer)

kdev_t compilation fixes (Framebuffer)

Post by Bongani Hlop » Mon, 25 Feb 2002 06:50:11



I misspelled patch on the subject of the first mail, some plp's filters
may miss it (I guess) so here it goes again.

I thinks these were missed during 2.5.2-pre6, Feren I hope you are
the right person to send the for the first patch (your name is listed as
the Maintainer),Gerd yours is listed for the second patch.

        --Bongani

--- linux-2.5/drivers/video/riva/fbdev.c        Thu Nov 15 00:52:20 2001

        info = &rinfo->info;

        strcpy(info->modename, rinfo->drvr_name);
-       info->node = -1;
+       info->node = NODEV;
        info->flags = FBINFO_FLAG_DEFAULT;
        info->fbops = &riva_fb_ops;

--- linux-2.5/drivers/video/sis/sis_main.c      Thu Feb 21 23:56:03 2002

        sisfb_crtc_to_var (&default_var);

        fb_info.changevar = NULL;
-       fb_info.node = -1;
+       fb_info.node = NODEV;
        fb_info.fbops = &sisfb_ops;
        fb_info.disp = &disp;
        fb_info.switch_con = &sisfb_switch;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

kdev_t compilation fixes (Framebuffer)

Post by Bakonyi Feren » Mon, 25 Feb 2002 20:20:07


        Hi!


> I thinks these were missed during 2.5.2-pre6, Feren I hope you are
> the right person to send the for the first patch (your name is listed as
> the Maintainer),Gerd yours is listed for the second patch.

Your patch is already included in the dj-tree, but it is missed from
Linus' tree. BTW Ani Joshi is listed as the maintainer, not me. :)

Best regards:
        Ferenc Bakonyi

--- linux-2.5/drivers/video/riva/fbdev.c        Thu Nov 15 00:52:20 2001

        info = &rinfo->info;

        strcpy(info->modename, rinfo->drvr_name);
-       info->node = -1;
+       info->node = NODEV;
        info->flags = FBINFO_FLAG_DEFAULT;
        info->fbops = &riva_fb_ops;

--- linux-2.5/drivers/video/sis/sis_main.c      Thu Feb 21 23:56:03 2002

        sisfb_crtc_to_var (&default_var);

        fb_info.changevar = NULL;
-       fb_info.node = -1;
+       fb_info.node = NODEV;
        fb_info.fbops = &sisfb_ops;
        fb_info.disp = &disp;
        fb_info.switch_con = &sisfb_switch;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Patch?: linux-2.5.2-pre8/drivers/video kdev_t compilation fixes

        Most (all?) of the frame buffer drivers in
linux-2.5.2-pre8/drivers/video have a kdev_t compilation error,
because they try to set their fb_info->node field to -1 (it is
a kdev_t).  Shortly thereafter, regsiter_framebuffer sets it to
a more useful value.  So far, I have been unable to spot any
code that relies on fb_info->node being initialized to a
particular value prior to the call to register_framebuffer,
although I have not looked very hard.  What I did see was
some "???" comments beside some of the initializations to -1.
I suspsect that this is just useless initialization.

        Anyhow, deleting all of those initializations to -1
allows all of the framebuffer drivers to compile, which is
that this patch does.  I have also included a tiny patch to
a commented out line in include/linux/fb.h, updating it to
use minor() instead of MINOR(), in case it is every uncommented.

        I am still a long way from getting pre8 to run, so I
have not tested change.  Can anyone point out a place in
drivers/framebuffer that relies on fb_info->node being set to -1,
or minor(fb_info->node) being -1?

        By the way, don't worry if a few of the line offsets in this
patch are off.  That's because of some other changes I have in my
drivers/framebuffer (which I have previous posted, specifically
PCI ID tables, fb font modularization with demand loading, and the
fb core as a loadable module).

--
Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104

+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."

  video.diff
21K Download

2. BTTV (module?)

3. Patch: linux-2.5.2-pre8/drivers/ieee1394 kdev_t compilation fixes

4. newbie DIP/PPP question

5. linux-2.5.2-pre8/drivers/telephony kdev_t compilation fixes

6. (no subject)

7. Assorted kdev_t fixes

8. SuSE Linux 6.4 hangs while CD-installation

9. PATCH: linux-2.5.2-pre7/drivers/block/rd.c kdev_t fix

10. Fix kdev_t in sr, st, sg (2.5.2-pre6)

11. PATCH 2.5.2.9: fbdev kdev_t build fixes

12. Fix kdev_t in sr, st, sg

13. compile fix for 2.5 kdev_t compatibility macros