2.5.3-dj5 synclink.c fix so that it compiles

2.5.3-dj5 synclink.c fix so that it compiles

Post by reddog8 » Tue, 12 Feb 2002 14:20:09



This is a temp fix for thje synclink.c file in drivers/char it work's for me
so DJ will you please apply this patch.
Thank you Victor Torres.
All it does it removes the #error please convert me to
Documentation/DMA-mapping.txt
it compiles and work's great for me.
Please apply

  synclink.diff
< 1K Download
 
 
 

2.5.3-dj5 synclink.c fix so that it compiles

Post by Jens Axbo » Tue, 12 Feb 2002 19:00:10



> This is a temp fix for thje synclink.c file in drivers/char it work's for me
> so DJ will you please apply this patch.
> Thank you Victor Torres.
> All it does it removes the #error please convert me to
> Documentation/DMA-mapping.txt
> it compiles and work's great for me.

I find this _really_ hard to believe. It may compile, but does it link?

Quote:> Please apply

Not really

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.5.3-dj5 synclink.c fix so that it compiles

Post by reddog8 » Wed, 13 Feb 2002 05:50:15


Paul-
That is understandable. I had  the same guess as you when I made this patch.
Why is ths synclink.c driver using DMA Mapping. After I took that line out I
was fine becuase my system is fine.


> > This is a temp fix for thje synclink.c file in drivers/char it work's for

> me

> > so DJ will you please apply this patch.
> > Thank you Victor Torres.
> > All it does it removes the #error please convert me to
> > Documentation/DMA-mapping.txt
> > it compiles and work's great for me.
> > Please apply

> There is nothing in the DMA-mapping.txt that
> applies to the PCI version of the synclink adapter
> (which does not do DMA to/from system memory).

> The ISA version of the synclink adapter does do
> ISA DMA bus master transfers. After reading
> DMA-mapping.txt twice it is unclear what changes
> need to be applied. The documentation seems to imply
> that ISA devices need to make some pci_xxx calls.
> I'm not sure how this works when there is no PCI bus.

> For now, removing the #error line should work fine
> for the PCI adapter and probably for the ISA as well.

> I will look at this again as time allows.

> I usually wait 6-12 months after the new development
> kernel opens before attempting to sync my drivers
> to the latest changes. This avoids most of the eat-your-file-system
> phase, prevents wasting time chasing after a rapidly changing API,
> and still leaves another 12 months for tweaking.


> Microgate Corporation, www.microgate.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
 
 
 

2.5.3-dj5 synclink.c fix so that it compiles

Post by Jens Axbo » Wed, 13 Feb 2002 16:00:12



> Paul-
> That is understandable. I had  the same guess as you when I made this patch.
> Why is ths synclink.c driver using DMA Mapping. After I took that line out I
> was fine becuase my system is fine.

The "real" fix for synclink is just something like this, afaics.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#                  ChangeSet    1.275   -> 1.276  
#       drivers/char/synclink.c 1.11    -> 1.12  
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------

# synclink is an ISA-only driver, so just use isa_virt_to_bus to make
# it work
# --------------------------------------------
#
diff -Nru a/drivers/char/synclink.c b/drivers/char/synclink.c
--- a/drivers/char/synclink.c   Tue Feb 12 07:55:54 2002

 #  define BREAKPOINT() { }
 #endif

-#error Please convert me to Documentation/DMA-mapping.txt
-
 #define MAX_ISA_DEVICES 10
 #define MAX_PCI_DEVICES 10

                if ( info->buffer_list == NULL )
                        return -ENOMEM;

-               info->buffer_list_phys = virt_to_bus(info->buffer_list);
+               info->buffer_list_phys = isa_virt_to_bus(info->buffer_list);
        }


                                kmalloc(DMABUFFERSIZE, GFP_KERNEL | GFP_DMA);
                        if ( BufferList[i].virt_addr == NULL )
                                return -ENOMEM;
-                       phys_addr = virt_to_bus(BufferList[i].virt_addr);
+                       phys_addr = isa_virt_to_bus(BufferList[i].virt_addr);
                }
                BufferList[i].phys_addr = phys_addr;
        }

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.5.3-dj5 synclink.c fix so that it compiles

Post by Jens Axbo » Wed, 13 Feb 2002 16:10:13





> > > Paul-
> > > That is understandable. I had  the same guess as you when I made this patch.
> > > Why is ths synclink.c driver using DMA Mapping. After I took that line out I
> > > was fine becuase my system is fine.

> > The "real" fix for synclink is just something like this, afaics.

> Agrh, scratch that. It's not ISA only of course, my bad.

For fsck sake, that path was ISA only... Ok, time for coffee.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.5.3-dj5 synclink.c fix so that it compiles

Post by Paul Fulghu » Wed, 13 Feb 2002 23:30:23


Quote:> >    The "real" fix for synclink is just something like this, afaics.

> > It is a PCI driver Jens, this change is not correct.

> See my repeated follow-ups :-)

It is an ISA and PCI driver, but only the ISA adapter
uses DMA and requires DMA mapping.

Thanks for the patch Jens.


Microgate Corporation, www.microgate.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. mod_timer fix for synclink.c

synclink.c: trivial {del,add}_timer to mod_timer conversion.

--- linux-2.5.68/drivers/char/synclink.c        2003-03-25 10:07:40.000000000 +0530

                                info->get_tx_holding_index=0;

                        /* restart transmit timer */
-                       del_timer(&info->tx_timer);
-                       info->tx_timer.expires = jiffies + jiffies_from_ms(5000);
-                       add_timer(&info->tx_timer);
+                       mod_timer(&info->tx_timer, jiffies + jiffies_from_ms(5000));

                        ret = 1;
                }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Help! printing error

3. It`s IMPORTANT!!!

4. ASUS ADLS PCI

5. Please Help....it′s a very small thing!!!!.PLEASE

6. one route quesion under Linux?

7. Linux 2.5.3-dj5

8. URGENT: Help! Need to add Apache Server Extension

9. Help me !!!!!! I have no Idea it′s crucial

10. filesystem corruption with 2.5.2-dj5

11. It`s IMPORTANT!!!

12. 2.5.2-dj5 linking error

13. 2.5.69 synclink.c