2.5.74 xattr fixes

2.5.74 xattr fixes

Post by <ffreder.. » Fri, 04 Jul 2003 12:00:31



Fabian Frederick:
-Removed old BKL comments
-Typo fix
-Doc precision

PS : Someone could check if lock_super is still needed there ?

--- linux-2.5.74/fs/ext2/xattr.c        2003-07-03 09:34:35.000000000 +0200

  *   +------------------+
  *
  * The block header is followed by multiple entry descriptors. These entry
- * descriptors are variable in size, and alligned to EXT2_XATTR_PAD
+ * descriptors are variable in size, and aligned to EXT2_XATTR_PAD
  * byte boundaries. The entry descriptors are sorted by attribute name,
  * so that two extended attribute blocks can be compared efficiently.

 ext2_xattr_handler(int name_index)
 {
        struct ext2_xattr_handler *handler = NULL;
+
        if (name_index > 0 && name_index <= EXT2_XATTR_INDEX_MAX) {
                read_lock(&ext2_handler_lock);

  * Inode operation getxattr()
  *
  * dentry->d_inode->i_sem down
- * BKL held [before 2.5.x]
  */
 ssize_t

  * Inode operation listxattr()
  *
  * dentry->d_inode->i_sem down
- * BKL held [before 2.5.x]
  */
 ssize_t

  * Inode operation setxattr()
  *
  * dentry->d_inode->i_sem down
- * BKL held [before 2.5.x]
  */
 int

  * Inode operation removexattr()
  *
  * dentry->d_inode->i_sem down
- * BKL held [before 2.5.x]
  */
 int

                        set_buffer_uptodate(new_bh);
                        unlock_buffer(new_bh);
                        ext2_xattr_cache_insert(new_bh);
-                      
                        ext2_xattr_update_super_block(sb);
                }

  * Create a new entry in the extended attribute cache, and insert
  * it unless such an entry is already in the cache.
  *
- * Returns 0, or a negative error number on failure.
+ * Returns 0 (ok) or -ENOMEM on failure.
  */
 static int

               struct ext2_xattr_header *header2)
 {
        struct ext2_xattr_entry *entry1, *entry2;
-
+       /* First entry available after xattr_header */
        entry1 = ENTRY(header1+1);
        entry2 = ENTRY(header2+1);
        while (!IS_LAST_ENTRY(entry1)) {

___________________________________

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. (trivial 2.5.74) compilation fix drivers/mtd/mtd_blkdevs.c

C does not let us declar variables in the middle of a block (yet).

--- 2.5.74/drivers/mtd/mtd_blkdevs.c    2003-07-03 01:32:27.000000000 -0700

        case HDIO_GETGEO:
                if (tr->getgeo) {
                        struct hd_geometry g;
+                       int ret;

                        memset(&g, 0, sizeof(g));
-                       int ret = tr->getgeo(dev, &g);
+                       ret = tr->getgeo(dev, &g);
                        if (ret)
                                return ret;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. set tabsize in vi

3. [2.5.74] fix x86_64 breakage on UP with modules

4. re-cover from rm * ~/misc/test/

5. 2.5.74 does not boot with TCQ: Unable to handle NULL pointer dereference

6. Number of free memory pages

7. 2.5.74 synclink_cs.c

8. ip adress

9. 2.5.74 synclink.c

10. 2.5.74: ALSA lockups, and ACPI, IRQ routing

11. cdrom problems in 2.5.74

12. [ANNOUNCE] kexec for 2.5.74 available

13. 2.5.74 with contest