2.4.19-pre10-ac2, compile warnings/failures

2.4.19-pre10-ac2, compile warnings/failures

Post by David For » Wed, 12 Jun 2002 06:30:10



cpqphp.h: In function `cpq_get_latch_status':
cpqphp.h:698: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h: In function `wait_for_ctrl_irq':
cpqphp.h:736: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h:746: warning: concatenation of string literals with
__FUNCTION__ is deprecated

cpqphp_nvram.c:163: warning: concatenation of string literals with
__FUNCTION__ is deprecated

cpqphp_nvram.c:179:17: missing terminating " character
cpqphp_nvram.c: In function `access_EV':
cpqphp_nvram.c:180: parse error before "xorl"
cpqphp_nvram.c:184:28: missing terminating " character

People, please don't do things like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl   %%ebx,%%ebx
      xorl    %%edx,%%edx
      pushf
      push    %%cs
      cli
      call    *%6"

Patches keep going in to fix this.

Please do something like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl   %%ebx,%%ebx  \n"
      "xorl    %%edx,%%edx \n"
      "pushf               \n"
      "push    %%cs        \n"
      "cli                 \n"
      "call    *%6         \n"

i2o_core.c:3393:75: missing terminating " character
         printk(KERN_WARNING "i2o: Could not quiesce %s."  "
            Verify setup on next system power up.\n", c->name);

Please write it like:

         printk(KERN_WARNING "i2o: Could not quiesce %s."  
            "Verify setup on next system power up.\n", c->name);

-d

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.4.19-pre10-ac2, compile warnings/failures

Post by Thunder from the hil » Wed, 12 Jun 2002 10:10:05


Hi,


> People, please don't do things like:

> [bad use of doublequotes]

> Patches keep going in to fix this.

> [good use of doublequotes]

The same applies to 2.5. Can someone write a perl script that treats it so
anonymous that it can find these buggy places?

Index: drivers/message/i2o/i2o_core.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/message/i2o/i2o_core.c,v
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/message/i2o/i2o_core.c  10 Jun 2002 15:17:07 -0000      1.1

        {
                if(i2o_quiesce_controller(c))
                {
-                       printk(KERN_WARNING "i2o: Could not quiesce %s."  "
-                               Verify setup on next system power up.\n", c->name);
+                       printk(KERN_WARNING "i2o: Could not quiesce %s."
+                              "Verify setup on next system power up.\n",
+                              c->name);
                }
        }

Index: drivers/hotplug/cpqphp_nvram.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/hotplug/cpqphp_nvram.c,v
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/hotplug/cpqphp_nvram.c  10 Jun 2002 15:13:54 -0000      1.1

        spin_lock_irqsave(&int15_lock, flags);
        __asm__ (
-               "xorl   %%ebx,%%ebx
-               xorl    %%edx,%%edx
-               pushf
-               push    %%cs
-               cli
-               call    *%6"
+               "xorl   %%ebx,%%ebx \n"
+               "xorl   %%edx,%%edx \n"
+               "pushf              \n"
+               "push    %%cs       \n"
+               "cli                \n"
+               "call    *%6        \n"
                : "=c" (*buf_size), "=a" (ret_val)
                : "a" (op), "c" (*buf_size), "S" (ev_name),
                "D" (buffer), "m" (compaq_int15_entry_point)

Regards,
Thunder
--
German attitude becoming        |       Thunder from the hill at ngforever
rightaway popular:              |
       "Get outa my way,   |       free inhabitant not directly
    for I got a mobile phone!"     |       belonging anywhere

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.4.19-pre10-ac2, compile warnings/failures

Post by Thunder from the hil » Wed, 12 Jun 2002 10:30:06


Hi,



> > -                     printk(KERN_WARNING "i2o: Could not quiesce %s."  "
> > -                             Verify setup on next system power up.\n", c->name);
> > +                     printk(KERN_WARNING "i2o: Could not quiesce %s."
> > +                            "Verify setup on next system power up.\n",
> > +                            c->name);

> Don't we lose a \n if you do that?  Speaking of, is "\n" better, or "  "
> I wonder...  ;)

You're right, here comes the accurate version:

Index: drivers/message/i2o/i2o_core.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/message/i2o/i2o_core.c,v
retrieving revision 1.1
diff -u -3 -p -r1.1 i2o_core.c
--- thunder-2.5/drivers/message/i2o/i2o_core.c  10 Jun 2002 15:17:07 -0000      1.1

        {
                if(i2o_quiesce_controller(c))
                {
-                       printk(KERN_WARNING "i2o: Could not quiesce %s."  "
-                               Verify setup on next system power up.\n", c->name);
+                       printk(KERN_WARNING "i2o: Could not quiesce %s.\n"
+                              "Verify setup on next system power up.\n",
+                              c->name);
                }
        }

Index: drivers/hotplug/cpqphp_nvram.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/hotplug/cpqphp_nvram.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/hotplug/cpqphp_nvram.c  10 Jun 2002 15:13:54 -0000      1.1

        spin_lock_irqsave(&int15_lock, flags);
        __asm__ (
-               "xorl   %%ebx,%%ebx
-               xorl    %%edx,%%edx
-               pushf
-               push    %%cs
-               cli
-               call    *%6"
+               "xorl   %%ebx,%%ebx \n"
+               "xorl   %%edx,%%edx \n"
+               "pushf              \n"
+               "push    %%cs       \n"
+               "cli                \n"
+               "call    *%6        \n"
                : "=c" (*buf_size), "=a" (ret_val)
                : "a" (op), "c" (*buf_size), "S" (ev_name),
                "D" (buffer), "m" (compaq_int15_entry_point)

Regards,
Thunder
--
German attitude becoming        |       Thunder from the hill at ngforever
rightaway popular:              |
       "Get outa my way,   |       free inhabitant not directly
    for I got a mobile phone!"     |       belonging anywhere

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.4.19-pre10-ac2, compile warnings/failures

Post by David For » Wed, 12 Jun 2002 12:10:04


My choice was to drop the \n, I don't like very short statements spread
over multiple lines especially if I'm grepping for things.

That's why I chose not to include a \n.

-d


>Hi,



>>>-                   printk(KERN_WARNING "i2o: Could not quiesce %s."  "
>>>-                           Verify setup on next system power up.\n", c->name);
>>>+                   printk(KERN_WARNING "i2o: Could not quiesce %s."
>>>+                          "Verify setup on next system power up.\n",
>>>+                          c->name);

>>Don't we lose a \n if you do that?  Speaking of, is "\n" better, or "  "
>>I wonder...  ;)

>You're right, here comes the accurate version:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
 
 
 

2.4.19-pre10-ac2, compile warnings/failures

Post by Greg K » Wed, 12 Jun 2002 15:10:06



> Hi,


> > People, please don't do things like:

> > [bad use of doublequotes]

> > Patches keep going in to fix this.

> > [good use of doublequotes]

> The same applies to 2.5. Can someone write a perl script that treats it so
> anonymous that it can find these buggy places?

And could someone actually _tell_ the maintainers of these drivers that
there is a problem?  And what compiler version causes it?

This the first I've heard of this problem.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.4.19-pre10-ac2, compile warnings/failures

Post by David For » Wed, 12 Jun 2002 23:20:12


It's been brought up over and over the last couple of years.  GCC
started warning about it quite a while ago and it's been named as a bad
form.  Patches to fix various things have been submitted sporadically
for a long time as well.  Future versions of GCC will mark it as an error.

David



>>Hi,


>>>People, please don't do things like:

>>>[bad use of doublequotes]

>>>Patches keep going in to fix this.

>>>[good use of doublequotes]

>>The same applies to 2.5. Can someone write a perl script that treats it so
>>anonymous that it can find these buggy places?

>And could someone actually _tell_ the maintainers of these drivers that
>there is a problem?  And what compiler version causes it?

>This the first I've heard of this problem.

>greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/