Remove 3 compiler warnings from rio_linux.c

Remove 3 compiler warnings from rio_linux.c

Post by Bob Mille » Sun, 22 Jun 2003 00:20:07



Add a return value to a return statement in the ISR and remove/rename
several labels.

--

Open Source Development Lab                     Phone: 503.626.2455 Ext. 17

diff -Nru a/drivers/char/rio/rio_linux.c b/drivers/char/rio/rio_linux.c
--- a/drivers/char/rio/rio_linux.c      Fri Jun 20 13:57:08 2003

     rio_reset_interrupt (HostP);
   }

-  if ((HostP->Flags & RUN_STATE) != RC_RUNNING) return;
+  if ((HostP->Flags & RUN_STATE) != RC_RUNNING) return IRQ_NONE;

   if (test_and_set_bit (RIO_BOARD_INTR_LOCK, &HostP->locks)) {

   for (i = 0; i < RIO_PORTS; i++) {
     port = p->RIOPortp[i] = ckmalloc (sizeof (struct Port));
     if (!port) {
-      goto free6;
+      goto free3;
     }
     rio_dprintk (RIO_DEBUG_INIT, "initing port %d (%d)\n", i, port->Mapped);

   func_exit();
   return 0;

- free6:for (i--;i>=0;i--)
+ free3:for (i--;i>=0;i--)
         kfree (p->RIOPortp[i]);
-/*free5: */
- free4:
- free3:kfree (p->RIOPortp);
+  kfree (p->RIOPortp);
  free2:kfree (p->RIOHosts);
  free1:
   rio_dprintk (RIO_DEBUG_INIT, "Not enough memory! %p %p %p\n",

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Fix compiler errors in drivers/char/rio/rio_linux.c

When the compatmac.h include file was deleted the indirect include
of asm/uaccess.h was lost.  This patch adds a direct include of
asm/uaccess.h.

This fixes bugme.osdl.org bug number 566.

--

Open Source Development Lab                     Phone: 503.626.2455 Ext. 17

===== drivers/char/rio/rio_linux.c 1.16 vs edited =====
--- 1.16/drivers/char/rio/rio_linux.c   Mon Mar 31 15:55:28 2003

 #include <linux/init.h>

 #include <linux/generic_serial.h>
+#include <asm/uaccess.h>

 #if BITS_PER_LONG != 32
 #  error FIXME: this driver only works on 32-bit platforms
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. dst cache overflow

3. compiler warnings going from WorkShop 4.2 to WorkShop 6 update 1

4. Mitsumi 1X problem

5. 2.4: Fix for jbd compiler warnings.

6. AIX to Interne via proxy server

7. Remove compile warning from drivers/ide/pci/cs5520.c

8. rshing Ultrix xterms

9. Remove sudo warning

10. [ATM] prevent compiler warning when compiling w/o bridging

11. 2.4.20pre5 trivial compiler warning fix for fmvj18x_cs.c

12. tpqic02 - compiler warning ?

13. New: Removing wireless card triggers might_sleep warnings