ide-tape.c must include buffer_head.h

ide-tape.c must include buffer_head.h

Post by Adrian Bun » Tue, 28 May 2002 06:10:10



Hi Christoph,

after your removal of #include <linux/buffer_head.h> from fs.h ide-tape.c
no longer compiles:

<--  snip  -->

...
gcc -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.18-modular/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -DMODULE -DMODVERSIONS
-include /home/bunk/linux/kernel-2.5/linux-2.5.18-modular/include/linux/modversions.h
-DKBUILD_BASENAME=ide_tape  -c -o ide-tape.o ide-tape.c
ide-tape.c: In function `__idetape_kmalloc_stage':
ide-tape.c:2810: `BH_Lock' undeclared (first use in this function)
ide-tape.c:2810: (Each undeclared identifier is reported only once
ide-tape.c:2810: for each function it appears in.)
...

<--  snip  -->

The following patch (made against 2.5.18-dj1 but it should apply cleanly
against 2.5.18) fixes it (I wasn't able to find an obvious ordering of the
"#include <linux/*>" so I placed it at the end):

--- drivers/ide/ide-tape.c.old  Sun May 26 22:55:56 2002

 #include <linux/completion.h>
 #include <linux/ide.h>
 #include <linux/atapi.h>
+#include <linux/buffer_head.h>

 #include <asm/byteorder.h>
 #include <asm/irq.h>

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
                                                                Alan Cox

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

ide-tape.c must include buffer_head.h

Post by Jens Axbo » Thu, 30 May 2002 20:00:13



> Hi Christoph,

> after your removal of #include <linux/buffer_head.h> from fs.h ide-tape.c
> no longer compiles:

The usage of BH_Lock is completely wrong in ide-tape! BH_Lock is a
buffer_head flag, but it's setting/clearing the bio flags. Whoever did
that 2.5 conversion messed that part up.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/