pcihpfs problems in 2.4.19

pcihpfs problems in 2.4.19

Post by Greg K » Thu, 15 Aug 2002 05:10:03




> I just started testing the cPCI hotplug driver I'm working on against
> 2.4.19 after upgrading the kernel in SOMA's in-house distribution,
> and I'm now getting the attached oops code when trying to access the
> pcihpfs (e.g. with ls) after mounting it.  I backed out the couple of
> changes I made last night that might have been remotely connected
> (added hardware_test and get_power_status hotplug ops in my driver),
> and I'm still getting it in the same place, so it looks like maybe a
> VFS change somewhere in 2.4.19 broke pcihpfs.  Any ideas?

Ah, looks like a change with readdir.c in 2.4.19-pre2 caused this
problem.  Please try the attached patch, it fixes the problem for me.

Thanks to Dan Stekloff for helping in finding this fix.

thanks,

greg k-h

diff -Nru a/drivers/hotplug/pci_hotplug_core.c b/drivers/hotplug/pci_hotplug_core.c
--- a/drivers/hotplug/pci_hotplug_core.c        Tue Aug 13 12:57:16 2002

 };

 static struct super_operations pcihpfs_ops;
-static struct file_operations pcihpfs_dir_operations;
 static struct file_operations default_file_operations;
 static struct inode_operations pcihpfs_dir_inode_operations;

                        break;
                case S_IFDIR:
                        inode->i_op = &pcihpfs_dir_inode_operations;
-                       inode->i_fop = &pcihpfs_dir_operations;
+                       inode->i_fop = &dcache_dir_ops;
                        break;
                }

        return 0;
 }
-
-static struct file_operations pcihpfs_dir_operations = {
-       read:           generic_read_dir,
-       readdir:        dcache_readdir,
-};

 static struct file_operations default_file_operations = {
        read:           default_read_file,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

pcihpfs problems in 2.4.19

Post by Scott Murra » Sun, 01 Sep 2002 01:30:10




> > I just started testing the cPCI hotplug driver I'm working on against
> > 2.4.19 after upgrading the kernel in SOMA's in-house distribution,
> > and I'm now getting the attached oops code when trying to access the
> > pcihpfs (e.g. with ls) after mounting it.  I backed out the couple of
> > changes I made last night that might have been remotely connected
> > (added hardware_test and get_power_status hotplug ops in my driver),
> > and I'm still getting it in the same place, so it looks like maybe a
> > VFS change somewhere in 2.4.19 broke pcihpfs.  Any ideas?

> Ah, looks like a change with readdir.c in 2.4.19-pre2 caused this
> problem.  Please try the attached patch, it fixes the problem for me.

I've finally gotten around to trying this out after coming back from
vacation, and have verified that it fixes the problem for me.

Quote:> Thanks to Dan Stekloff for helping in finding this fix.

Ditto, I wan't enjoying the prospect of trying to debug this myself.

Scott

--
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. pcihpfs problems in 2.4.19

Hm, I just verified this on one of my machines, but a different one
(ia64 box) works just fine.  I'll dig and try to find the problem later
on today.  As a side note, someone who based their code off of pcihpfs
also has the same problem, so I think it's some vfs change that I didn't
catch.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Group access ?

3. 2.4.19-rc2 -> 2.4.19-rc3 : no more eth (fwd)

4. CD RW for RedHat 7.2

5. 3Ware ok 2.4.19, dies 2.4.19-ac4

6. color xterm gives "Error 24, errno 22: Invalid argument"

7. Promise 20267 hangs with 2.4.19-pre3 and 2.4.19-pre3-ac3

8. Xfree86 install

9. 2.4.19-pre6aa1 (possible all kernel after 2.4.19-pre2) athlon PCI workaround

10. Kernel panic 2.4.19-pre6 AND 2.4.19-pre5-ac3 - More info - ksymoops

11. kbuild25 version 3.0 for 2.4.19-pre9 and 2.4.19-pre9-ac3

12. PROBLEM: Oops in 2.4.19-pre8 - "kernel BUG at page_alloc.c:106!"

13. Problem with 2.4.19-pre10-ac2 and i2o SX6000 controller