2.5.60: JFS no longer compiles with gcc 2.95

2.5.60: JFS no longer compiles with gcc 2.95

Post by Adrian Bun » Tue, 11 Feb 2003 22:50:58




>...
> Summary of changes from v2.5.59 to v2.5.60
> ============================================
>...

>...
>   o JFS: replace ugly JFS debug macros with simpler ones
>...

This broke the compilation with gcc 2.95:

<--  snip  -->

...
  gcc -Wp,-MD,fs/jfs/.super.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include  
-D_JFS_4K  -DKBUILD_BASENAME=super -DKBUILD_MODNAME=jfs -c -o
fs/jfs/super.o fs/jfs/super.c
fs/jfs/super.c: In function `jfs_fill_super':
fs/jfs/super.c:335: parse error before `)'
make[2]: *** [fs/jfs/super.o] Error 1

<--  snip  -->

cu
Adrian

--

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.5.60: JFS no longer compiles with gcc 2.95

Post by James Lamann » Tue, 11 Feb 2003 23:50:13


Quote:>>> This broke the compilation with gcc 2.95:

<--  snip  -->
...
  gcc -Wp,-MD,fs/jfs/.super.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include  
-D_JFS_4K  -DKBUILD_BASENAME=super -DKBUILD_MODNAME=jfs -c -o
fs/jfs/super.o fs/jfs/super.c
fs/jfs/super.c: In function `jfs_fill_super':
fs/jfs/super.c:335: parse error before `)'
make[2]: *** [fs/jfs/super.o] Error 1
<--  snip  -->

Curious as to what gcc 2.95 version you are using.
Seems to compile fine with:
gcc 2.95.4 20011002

--James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

2.5.60: JFS no longer compiles with gcc 2.95

Post by Adrian Bun » Wed, 12 Feb 2003 09:40:03



> >>> This broke the compilation with gcc 2.95:
> <--  snip  -->
> ...
>   gcc -Wp,-MD,fs/jfs/.super.o.d -D__KERNEL__ -Iinclude -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=k6
> -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include  
> -D_JFS_4K  -DKBUILD_BASENAME=super -DKBUILD_MODNAME=jfs -c -o
> fs/jfs/super.o fs/jfs/super.c
> fs/jfs/super.c: In function `jfs_fill_super':
> fs/jfs/super.c:335: parse error before `)'
> make[2]: *** [fs/jfs/super.o] Error 1
> <--  snip  -->

> Curious as to what gcc 2.95 version you are using.
> Seems to compile fine with:
> gcc 2.95.4 20011002

I'm using the same gcc. I should have said that I'm compiling with
CONFIG_JFS_DEBUG. Without CONFIG_JFS_DEBUG it indeed compiles fine.

Quote:> --James

cu
Adrian

--

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. JFS no longer compiles with gcc 2.95

I'm not sure what's causing the problem, but Andrew Morton send me this
patch which gets rid of the problem for him.  The fmt string that
jfs_err() is invoked with is sufficient to identify the location, so
__FILE__ and __LINE__ are not really needed anyway.

Linus, please apply.

Thanks,
Shaggy

diff -puN fs/jfs/jfs_debug.h~jfs-build-fix fs/jfs/jfs_debug.h
--- 25/fs/jfs/jfs_debug.h~jfs-build-fix 2003-02-12 02:20:40.000000000
-0800

 /* error event message: e.g., i/o error */
 #define jfs_err(fmt, arg...) do {                      \
        if (jfsloglevel >= JFS_LOGLEVEL_ERR)         \
-               printk(KERN_ERR "%s:%d " fmt "\n",  \
-                      __FILE__, __LINE__, ## arg);     \
+               printk(KERN_ERR fmt "\n", ## arg);    \
 } while (0)

 /*

--
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. how can i start non-root programs at init?

3. 2.5.60: arlan.c no longer compiles

4. KDE 3 broken after sound card install

5. jfs breakage in 2.5.60

6. Linux kernel network booting

7. Fastest pattern search? grep or sed?

8. compile fail: 2.5.60-mm2

9. 2.5.60 Compile error

10. 2.5.60 fails compile -- net/Space.c -- 3c509

11. 2.5.60 : fs/ncpfs/sock.c compile error

12. Another Linux 2.5.60 Compile error