Linux 2.5.68 - Fix module_put after return in drivers/net/wan/n2.c

Linux 2.5.68 - Fix module_put after return in drivers/net/wan/n2.c

Post by Gabriel Deveny » Thu, 01 May 2003 22:10:09



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch applies to 2.5.68. It is a bug listed at kbugs.org. module_put is never executed because it is after return.

Please CC me with any discussion.
- --
Building the Future,
Gabriel Devenyi

- ---FILE---

- --- linux-2.5.68/drivers/net/wan/n2.c 2003-04-19 22:48:55.000000000 -0400

        int result = hdlc_open(hdlc);
        if (result) {
- -             return result;
                module_put(THIS_MODULE);
+               return result;
        }

        mcr &= port->phy_node ? ~DTR_PORT1 : ~DTR_PORT0; /* set DTR ON */

- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sXxm7I5UBdiZaF4RAu8kAJ0RKpz8xwzNovBJIgD/vd4f4hEAzQCeNKpI
USAyeWl6lmsVqOPEzV/r1tI=
=rplC
-----END PGP SIGNATURE-----

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

Linux 2.5.68 - Fix module_put after return in drivers/net/wan/n2.c

Post by Francois Romie » Fri, 02 May 2003 00:10:09



[linux-2.5.68/drivers/net/wan/n2.c]

Already fixed in Linus's repository.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Linux 2.5.68 - Fix module_put after return statement

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch applies to 2.5.68. Its listed on kbugs.org. The function module_put is never called because it is after return.

Please CC me with any discussion.
- --
Building the Future,
Gabriel Devenyi

- ---FILE---

- --- linux-2.5.68/drivers/net/wan/c101.c       2003-04-19 22:50:34.000000000 -0400

        int result = hdlc_open(hdlc);
        if (result) {
- -             return result;
                module_put(THIS_MODULE);
+               return result;
        }

        writeb(1, port->win0base + C101_DTR);

- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sXn/7I5UBdiZaF4RAitxAJ9UHBL/iO7nuElsJkIBTqivnGoGDQCfQYbj
6ZrVhEXv1ir82/V/KKHjEQI=
=xOsM
-----END PGP SIGNATURE-----

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Very basic questions

3. Linux 2.5.68 - Fix debug statement after return in devices/net/wireless/arlan.c

4. insmod

5. Linux 2.5.68 - Fix FreeXid after return in fs/cifs/inode.c

6. Support for Xircom PE III

7. 2.5.68 and 2.5.68-mm2

8. Samsuite/Flexlm

9. Linux 2.5.68 - Debug statement after return in drivers/block/paride/bpck6.c

10. KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68

11. 2.5.68 and 2.5.68-mm2

12. [2.5.68] kexec for 2.5.68 available

13. KernelJanitor: Convert remaining error returns to ret urn -E Linux 2.5.68