move an unused variable in sis_main.c

move an unused variable in sis_main.c

Post by maximilian attem » Fri, 04 Jul 2003 13:00:14



The patch below moves an used variable from drivers/video/sis/sis_main.c

i've tested the compilation with 2.5.74

please apply
maks

--- linux-2.5.74/drivers/video/sis/sis_main.c   Wed Jul  2 22:50:59 2003

        double drate = 0, hrate = 0;
        int found_mode = 0;
        int old_mode;
-       unsigned char reg;

        TWDEBUG("Inside do_set_var");

 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)      
+       unsigned char reg;
        inSISIDXREG(SISCR,0x34,reg);
        if(reg & 0x80) {
           printk(KERN_INFO "sisfb: Cannot change display mode, X server is active\n");

---
When your medical records are indexed in Google, something's wrong!
aaron kaplan

  application_pgp-signature_part
< 1K Download
 
 
 

move an unused variable in sis_main.c

Post by Adrian Bun » Fri, 04 Jul 2003 14:00:07



> The patch below moves an used variable from drivers/video/sis/sis_main.c

> i've tested the compilation with 2.5.74

> please apply
> maks

> --- linux-2.5.74/drivers/video/sis/sis_main.c      Wed Jul  2 22:50:59 2003
> +++ linux/drivers/video/sis/sis_main.c     Thu Jul  3 12:06:58 2003

>    double drate = 0, hrate = 0;
>    int found_mode = 0;
>    int old_mode;
> -  unsigned char reg;

>    TWDEBUG("Inside do_set_var");

>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> +  unsigned char reg;
>    inSISIDXREG(SISCR,0x34,reg);
>    if(reg & 0x80) {
>       printk(KERN_INFO "sisfb: Cannot change display mode, X server is active\n");

If TWDEBUG does anything your patch breaks the compilation on kernel 2.4
with gcc 2.95 .

cu
Adrian

--

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

move an unused variable in sis_main.c

Post by maximilian attem » Fri, 04 Jul 2003 14:10:08



> If TWDEBUG does anything your patch breaks the compilation on kernel 2.4
> with gcc 2.95 .

thx for your attention but
TWDEBUG is defined in drivers/video/sis/sis.h

#if 1
#define TWDEBUG(x)
#else
#define TWDEBUG(x) printk(KERN_INFO x "\n");
#endif

please correct me if it breaks one of this macros
maks

  application_pgp-signature_part
< 1K Download
 
 
 

move an unused variable in sis_main.c

Post by maximilian attem » Fri, 04 Jul 2003 15:50:14


it's the one in kernel version 2.5.73 !!


> The version of sisfb you are dealing with is outdated. James Simmons has
> a newer one, and the absolute current one is on my website.

what prevents you from merging?

cu maks

  application_pgp-signature_part
< 1K Download
 
 
 

move an unused variable in sis_main.c

Post by Thomas Winischhofe » Fri, 04 Jul 2003 17:00:37



> it's the one in kernel version 2.5.73 !!


>>The version of sisfb you are dealing with is outdated. James Simmons has
>>a newer one, and the absolute current one is on my website.

> what prevents you from merging?

My name isn't Linus, and James is the maintainer of the fb stuff. Go bug
him...

Thomas

--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          http://www.winischhofer.net/
twini AT xfree86 DOT org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

move an unused variable in sis_main.c

Post by maximilian attem » Fri, 04 Jul 2003 17:50:19




> >>The version of sisfb you are dealing with is outdated. James Simmons has
> >>a newer one, and the absolute current one is on my website.

> >what prevents you from merging?

> My name isn't Linus, and James is the maintainer of the fb stuff. Go bug
> him...

hey i didn't want to bug you, you told me that the version was outdated.
i just wanted to know if there are any blocking technichal issues? :)

a++ maks

  application_pgp-signature_part
< 1K Download
 
 
 

move an unused variable in sis_main.c

Post by Thomas Winischhofe » Fri, 04 Jul 2003 18:10:09



>>>what prevents you from merging?

>>My name isn't Linus, and James is the maintainer of the fb stuff. Go bug
>>him...

> hey i didn't want to bug you, you told me that the version was outdated.
> i just wanted to know if there are any blocking technichal issues? :)

No offence taken (mutually, I hope :) AFAIK there are no technical
issues; please ask James what keeps him from doing that.

Thomas

--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          http://www.winischhofer.net/
twini AT xfree86 DOT org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. [TRIVIAL] remove agpgart_be.c unused variables

This patch removes a few un-needed variables in agpgart_be.c.  Patch is
against 2.4.19-pre10.

--- linux-clean/drivers/char/agp/agpgart_be.c   Fri Jun  7 23:41:55 2002

 static void agp_generic_agp_enable(u32 mode)
 {
        struct pci_dev *device = NULL;
-       u32 command, scratch, cap_id;
+       u32 command, scratch;
        u8 cap_ptr;


 {
        struct pci_dev *dev = NULL;
        u8 cap_ptr = 0x00;
-       u32 cap_id, scratch;

        if ((dev = pci_find_class(PCI_CLASS_BRIDGE_HOST << 8, NULL)) == NULL)
                return -ENODEV;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Links

3. remove unused variable in wacom driver

4. libc.so.4.5.19 - trojan?!

5. [PATCH][TRIVIAL] cpufreq/longrun.c : eliminate unused variable

6. Recreating /dev/cua0

7. fix warning: unused variable powernow-k6.c

8. update pppd need help

9. ipv4: 2.4.2: unused static variables

10. remove an unused variable from xirc2ps_cs.c

11. Remove unused variable from rsdump.c

12. remove unused variable from drivers/net/irda/ali-ircc.c

13. Unused variables in ppc64 prom.c