ACPI: compilation fixes

ACPI: compilation fixes

Post by Pavel Mache » Fri, 02 Aug 2002 21:20:05



Hi!

2.5.29 will not compile for me without these, please apply.

                                                                Pavel
--- clean/drivers/acpi/system.c Mon Jul 29 20:02:23 2002

        acpi_status             status = AE_ERROR;
        unsigned long           flags = 0;

-       save_flags(flags);
+       local_irq_save(flags);
+       local_irq_disable();

        switch (state)

                do_suspend_lowlevel(0);
                break;
        }
-       restore_flags(flags);
+       local_irq_restore(flags);

        return status;
 }

--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

ACPI: compilation fixes

Post by Matthew Wilco » Fri, 02 Aug 2002 22:50:05



> -  save_flags(flags);
> +  local_irq_save(flags);
> +  local_irq_disable();

umm.  local_irq_save disables interrupts:

#define local_irq_save(x)       __asm__ __volatile__("pushfl ; popl %0 ; cli":"=
g" (x): /* no input */ :"memory")

i think you're confused with local_save_flags.

--
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. Fixing ACPI compilation, fixing CONFIG_ACPI_BOOT

Hi!

Here are patches to fix CONFIG_ACPI_BOOT. This is 3rd or so
retransmit; I've seen no response at all. Please comment on the patch,
or it is going directly to Linus.

                                                                Pavel

--- clean/arch/i386/kernel/acpi.c       Mon Jun  3 11:43:27 2002

                               Boot-time Configuration
    -------------------------------------------------------------------------- */

-#ifdef CONFIG_ACPI_BOOT
-
 enum acpi_irq_model_id         acpi_irq_model;

-
+#ifdef CONFIG_ACPI_BOOT
 /*
  * Use reserved fixmap pages for physical-to-virtual mappings of ACPI tables.
  * Note that the same range is used for each table, so tables that need to
--- clean/include/linux/acpi.h  Mon Jun  3 11:43:38 2002

 #include <asm/acpi.h>

-#ifdef CONFIG_ACPI_BOOT
+#ifdef CONFIG_ACPI

 enum acpi_irq_model_id {
        ACPI_IRQ_MODEL_PIC = 0,

--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Compilation of sources from CVS

3. acpi compilation fix for 2.5.57

4. sequence of events when logging in?

5. 2.5.30 ACPI: fixing compilation

6. load-balanced PPP?

7. ACPI IRQ routing (was [ACPI] ACPI source release updated (200 11205))

8. WAKE UP ON LAN

9. ACPI constant overflow fixes

10. acpi compile fix

11. Linux 2.4.21-pre7 acpi warning fix

12. [PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled

13. 2.5.64 ACPI suspend/resume locking fix