vcdxrip , CDROM_SEND_PACKET, and 2.5.42->2.5.43 ide-cd changes

vcdxrip , CDROM_SEND_PACKET, and 2.5.42->2.5.43 ide-cd changes

Post by Paul E. Erkkil » Fri, 21 Feb 2003 18:30:17



Hi,

  I often use vcdxrip to pull mpeg data off of
old vcd's/svcds to archive to tape/dvd. This
worked fine in the 2.5 kernel series up to
2.5.42 where it worked after running the app
more then once ( i assumed it was an initialization
error someplace). After kernel 2.5.43 it no longer
works. I've sent mail to the authors and they
suggested switching it from using ioctl(CDROM_SEND_PACKET)
to ioctl(CDROMREADMODE2) , which does work only
a little slower.

 I've traced it down to cdrom_queue_packet_command() in ide-cd.c
returning a 0 error status from ide_do_drive_cmd(), and
req.data_len is 0, and there doesn't appear to be any sense
available.

I'd appreciate any suggestions for tracking this further
or ideas on possible causes.

-pee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

vcdxrip , CDROM_SEND_PACKET, and 2.5.42->2.5.43 ide-cd changes

Post by Jens Axbo » Fri, 21 Feb 2003 19:00:10



> Hi,

>  I often use vcdxrip to pull mpeg data off of
> old vcd's/svcds to archive to tape/dvd. This
> worked fine in the 2.5 kernel series up to
> 2.5.42 where it worked after running the app
> more then once ( i assumed it was an initialization
> error someplace). After kernel 2.5.43 it no longer
> works. I've sent mail to the authors and they
> suggested switching it from using ioctl(CDROM_SEND_PACKET)
> to ioctl(CDROMREADMODE2) , which does work only
> a little slower.

> I've traced it down to cdrom_queue_packet_command() in ide-cd.c
> returning a 0 error status from ide_do_drive_cmd(), and
> req.data_len is 0, and there doesn't appear to be any sense
> available.

Hmm interesting, nothing comes to mind right now. I'll try vcdxrip
myself, please tell me how you typically invoke it to produce the bug.

The best approach for 2.5.x and later is to use the SG_IO ioctl. It's
similar in spirit to CDROM_SEND_PACKET, but much faster. CDROMREADMODE2
should work too, of course.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/