list_for_each_entry

list_for_each_entry

Post by Rusty Russel » Thu, 22 Aug 2002 19:40:05



Using two variables all the time is pissing me off:

        struct list_head *i;
        list_for_each(i, &head) {
                struct foo *f = list_entry(i, struct foo, list);
                ...
        }

Much nicer is:
        struct foo *f;
        list_for_each_entry(f, &head, list) {
                ...
        }

Asm code produced is identical.

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Name: list_for_each_entry patch
Author: Rusty Russell
Status: Trivial

D: This adds list_for_each_entry, which is the equivalent of
D: list_for_each and list_entry, except only one variable is needed.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.4.19/include/linux/list.h working-2.4.19-conntrack-fast/include/linux/list.h
--- linux-2.4.19/include/linux/list.h   2002-08-21 18:14:34.000000000 +1000

        for (pos = (head)->prev, prefetch(pos->prev); pos != (head); \
                pos = pos->prev, prefetch(pos->prev))

+/**
+ * list_for_each_entry -       iterate over list of given type



+ */
+#define list_for_each_entry(pos, head, member)                         \
+       for (pos = list_entry((head)->next, typeof(*pos), member),   \
+                    prefetch(pos->member.next);                     \
+            &pos->member != (head);                                     \
+            pos = list_entry(pos->member.next, typeof(*pos), member),       \
+                    prefetch(pos->member.next))

 #endif /* __KERNEL__ || _LVM_H_INCLUDE */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
 
 

1. list_for_each_entry

List iteration pain removal patch.

Marcelo, Linus, please apply.
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Name: list_for_each_entry patch
Author: Rusty Russell
Status: Trivial

D: This adds list_for_each_entry, which is the equivalent of
D: list_for_each and list_entry, except only one variable is needed.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .5652-linux-2.5.31/include/linux/list.h .5652-linux-2.5.31.updated/include/linux/list.h
--- .5652-linux-2.5.31/include/linux/list.h     2002-08-02 11:15:10.000000000 +1000

        for (pos = (head)->next, n = pos->next; pos != (head); \
                pos = n, n = pos->next)

+/**
+ * list_for_each_entry -       iterate over list of given type



+ */
+#define list_for_each_entry(pos, head, member)                         \
+       for (pos = list_entry((head)->next, typeof(*pos), member),   \
+                    prefetch(pos->member.next);                     \
+            &pos->member != (head);                                     \
+            pos = list_entry(pos->member.next, typeof(*pos), member),       \
+                    prefetch(pos->member.next))
+
 #endif /* __KERNEL__ || _LVM_H_INCLUDE */

 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

2. Problems with 0.99E 3Com 3905B Driver

3. add safe version of list_for_each_entry() to list.h

4. I just install Corel 1.1 and....