Diff for src/interfaces/libpq/fe-connect.c between version 1.195

Diff for src/interfaces/libpq/fe-connect.c between version 1.195

Post by Bruce Momji » Sat, 12 Oct 2002 12:49:15




> Hello Bruce!

> You have patched fe-connect.c and dropeed out one check in line 1078:

> < while (rp == NULL || remains.tv_sec > 0 || (remains.tv_sec == 0 && remains.tv_usec > 0))
> ---
> > while (rp == NULL || remains.tv_sec > 0 || remains.tv_usec > 0)

> As I understand it is dangerous. The remains.tv_usec can be greater than zero while remains.tv_sec is below zero. It must exit form the loop in that conditions.

[ CC to hackers.]

Well, I can see how it could go negative, but if that happens, we have a
bigger problem.  tv_sec on my system is an unsigned int, so I think the
value will show as huge rather than negative.  If you want negative
values, I think you are going to need to use a real signed integer.
Would you send a context diff (diff -c) against CVS with a fix?

--
  Bruce Momjian                        |  http://candle.pha.pa.us

  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------

 
 
 

1. droped out precise time calculations in src/interfaces/libpq/fe-connect.c


I don't know.  Would you ask hackers list, and perhaps CC the author of
that patch.

---------------------------------------------------------------------------

----- End forwarded message -----

--
Regards
Denis

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command

2. MDI Frame Win Close Crash - Cannot Create Form. No MDI Forms are currently active

3. pgsql/src/interfaces/libpq (fe-connect.c libpq-fe.h libpq-int.h libpqdll.def)

4. Q: SQL Group By

5. pgsql/src/interfaces/libpq fe-exec.c libpq-fe.h

6. max table count in oracle

7. pgsql/src/interfaces/libpq libpq-fe.h libpq-int.h

8. DB Connection Problem

9. pgsql/src/interfaces/libpq fe-connect.c fe-misc.c

10. pgsql/src/interfaces/libpq fe-connect.c fe-exe ...h

11. pgsql/src/interfaces/libpq (fe-connect.c fe-exec.c)

12. pgsql/src/interfaces/libpq (libpq-fe.h)