F_SETLK is looking worse and worse...

F_SETLK is looking worse and worse...

Post by Bruce Momji » Mon, 11 Dec 2000 05:05:22

Quote:> However, I have no objection to writing the value of DataDir into
> the socket lockfile (along with the owner's PID) if that seems like
> a worthwhile bit of info.

> Would there be any value in having a postmaster re-read its own socket
> lockfile every so often, to keep it looking active to /tmp sweepers?
> Or is that too much of a kluge?

Removing 10-day-old files from /tmp seems pretty broken to me, and I
hate to code around broken stuff.

  Bruce Momjian                        |  http://candle.pha.pa.us

  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026


F_SETLK is looking worse and worse...

Post by Peter Eisentra » Tue, 12 Dec 2000 03:06:21

Quote:Bruce Momjian writes:
> Removing 10-day-old files from /tmp seems pretty broken to me, and I
> hate to code around broken stuff.

(It's not 10-day-old files, it's files that have not been used for 10

But both the Linux file system standard and POSIX 2 have requirements
and/or recommendations that call for /tmp to be cleaned out once in a
while.  If you don't like that, put your files elsewhere.  We're not in a
position to dictate system administration procedures.



1. F_SETLK is looking worse and worse...

While testing interlocking of multiple postmasters, I discovered that
the HAVE_FCNTL_SETLK interlock code we have in StreamServerPort()
does not work at all on HPUX 10.20.  This platform has F_SETLK according
to configure, but:

1. The lock is never applied to a socket, because the open() on the
newly-created socket (at line 303 of pqcomm.c) fails with EOPNOTSUPP,
Operation not supported.

2. If a postmaster finds a socket file in its way, it is unable to
remove it despite the lack of any lock, because the open() at line
230 fails with EADDRINUSE, Address already in use.

I have no idea whether the fcntl(F_SETLK) call would succeed if control
did get to it, but these results don't leave me very hopeful.

Between this and the already-known result that F_SETLK doesn't work on
sockets in shipping Linux kernels, I'm pretty unimpressed with the
usefulness of this interlock method.

We talked before about flushing the F_SETLK technique and using good
old interlock files containing PIDs, same method that we use for
interlocking the data directory.  That is, if the socket file name is
/tmp/.s.PGSQL.5432, we'd create a plain file /tmp/.s.PGSQL.5432.lock
containing the owning process's PID.  The code would insist on getting
this interlock file first, and if successful would just unconditionally
remove any existing socket file before doing the bind().

I can only think of one scenario where this is worse than what we have
now: if someone is running a /tmp-directory-sweeper that is bright
enough not to remove socket files, it would still zap the interlock
file, thus potentially allowing a second postmaster to take over the
socket file.  This doesn't seem like a mainstream problem though.

BTW, it also seems like a good idea to reorder the postmaster's
startup operations so that the data-directory lockfile is checked
before trying to acquire the port lockfile, instead of after.  That
way, in the common scenario where you're trying to start a second
postmaster in the same directory + same port, it'd fail cleanly
even if /tmp/.s.PGSQL.5432.lock had disappeared.


                        regards, tom lane

2. SUN Unix System Administrators --- Chelmsford, MA

3. Dual CPU box has worse SQL Server performance than single

4. Update Statistics shell script

5. MSDE Upgrade - It gets worse!

6. BCP and views

7. Memory issue - worse in SP3

8. MTS Oracle_XA performance tuning

9. SP fails badly

10. bcp behaving badly

11. Finding the worst Performance queries

12. DTS designed badly for parameter support with ODBC datasources

13. badly failed optimisation on simple query